[Omake] What comes after cons-hash?
Jason Hickey
jyh at cs.caltech.edu
Tue Mar 20 17:36:35 PDT 2007
Thanks for the fix, that's cool what you found!
The case-insensitive issue seems like a good plan. I think it should
be reasonably easy to detect. I guess on Linux, you can test with a
vfat filesystem.
A pending thought. We use SymbolTable a lot, so we might benefit
from hash-consed symbols. I'd suggest this as the better
alternative, but in 0.9.9 the dynamic environment becomes a
VirtualVarTable, and virtual_var are already hash-consed. The object
and private environments still use symbols. Those string comparisons
hurt performance.
Jason
On Mar 20, 2007, at 5:22 PM, Aleksey Nogin wrote:
> Jason,
>
> I think I am now fairly comfortable with the cons-hash patch and
> ready to move on. What do you want the next step(s) to be? Trying
> to figure out case insensitive filesystems?
>
> Aleksey
>
> On 20.03.2007 17:06, Aleksey Nogin wrote:
>
>> Further optimized the path code, finally bringing the performance
>> close to
>> what it was before the hash-cons patch was applied.
>> The problem was that when appending an extra path (which might
>> contain ".."
>> somehere inside) to a directory, it would fully reconstruct the
>> directory and
>> then construct it from scratch again. In presence of cons-hashing
>> this is
>> really expensive.
>> The obvious solution is not to deconstruct and only pop one level
>> every time
>> the ".." is encountered.
>> ----
>> Changes:
>> +29 -38 omake-branches/0.9.8.x/src/ir/omake_node.ml
>> A hyperlinked version of this commit is available at
>> http://svn.metaprl.org/commitlogs/omake/
>> 2007-03.html#07/03/20.17:06:04
>> _______________________________________________
>> OMake-CVS mailing list
>> OMake-CVS at metaprl.org
>> https://lists.metaprl.org/mailman/listinfo/omake-cvs
>
>
> --
> Aleksey Nogin, Research Staff Member
> Advanced Technologies Department, Information & System Sciences Lab
> HRL Laboratories, LLC, Malibu, CA
> _______________________________________________
> OMake-Devel mailing list
> OMake-Devel at metaprl.org
> https://lists.metaprl.org/mailman/listinfo/omake-devel
--
Jason Hickey http://www.cs.caltech.edu/~jyh
Caltech Computer Science Tel: 626-395-6568 FAX: 626-792-4257
More information about the OMake-Devel
mailing list