[Omake] SVN Commit: OMake Build System [0.9.8.x] (Rev. 11135)

[Jason Hickey]

My email was down, so I saw these messages in a strange order.

On the whole, I would say the changes are fine.  The only thing that  
bothers me is the organization.  Before, we had two (recursive)  
functions that created pipelines.  Now there are three, and one of  
them is create_job.  I'd still like to separate the concept of a  
pipeline from the specific externally-visible functions.

I see the point--the rhs of the pipeline should be toplevel, and this  
is what create_job does now.  Let me think about it.  It would be  
nice to have a generic pipeline function that implements the concept,  
instead of specifically for create_job.

Jason

On Jun 26, 2007, at 10:30 AM, Aleksey Nogin wrote:

> - Made the "exit n" Shell aliases work corrently again (only exit  
> from the
>   innermost Shell alias, not kill the whole shell session, as it  
> started doing
>   after the rev. 11110 fix to bug #679).
>   I fixed this by using the ExitParentException idea outlined in
>   http://lists.metaprl.org/pipermail/omake-devel/2007-June/000528.html
>
> - Pipelines like "(exit 5)" should not print a "Process group  
> exception" error
>   message; instead they should just return the appropriate exit code.
>   The fix is simple - just catch the ExitExceptions in appropriate  
> places.
>
> - Pipilines like "false || exit 5" should return the correct error  
> code, not
>   0. (This was broken in previous versions of OMake as well).
>   My fix is to have Omake_shell_job.create_job execute the PipeCond  
> pipelines
>   in the current process. (Added a TODO comment to do the same with  
> the
>   right-hand-sides of the PipeCompose pipelines).
>
> - Updated the test suite to catch some of the above problems.
>   Also updated the "omake clean" in the test directory to be a bit  
> more
>   thorough.
>
> ----
> Changes:
>     +1 -1	omake-branches/0.9.8.x/lib/Pervasives.om
>     +1 -0	omake-branches/0.9.8.x/src/build/omake_build.ml
>     +3 -1	omake-branches/0.9.8.x/src/build/omake_rule.ml
>     +7 -2	omake-branches/0.9.8.x/src/builtin/omake_builtin_base.ml
>     +2 -0	omake-branches/0.9.8.x/src/env/omake_exn_print.ml
>     +1 -0	omake-branches/0.9.8.x/src/ir/omake_value_type.ml
>     +119 -100	omake-branches/0.9.8.x/src/shell/omake_shell_job.ml
>     +8 -1	omake-branches/0.9.8.x/test/OMakefile
>     +9 -6	omake-branches/0.9.8.x/test/shell/Test3/run.osh
>     +18 -0	omake-branches/0.9.8.x/test/shell/Test4/run.osh
>
> A hyperlinked version of this commit is available at
> http://svn.metaprl.org/commitlogs/omake/2007-06.html#07/06/26.10:30:58
>
> _______________________________________________
> OMake-CVS mailing list
> OMake-CVS at metaprl.org
> https://lists.metaprl.org/mailman/listinfo/omake-cvs
>

--
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257