[Omake] SVN Commit: OMake Build System [0.9.8.x] (Rev. 11500)

[Aleksey Nogin]

On 31.07.2007 15:41, Jason Hickey wrote:

> On Jul 31, 2007, at 2:42 PM, Aleksey Nogin wrote:
> 
>> Fixed a problem with static environment being wiped out by hoisting.
>>
>> ----
>> Changes:
>>     +1 -1    omake-branches/0.9.8.x/src/env/omake_env.ml
> 
> This is not right, because (PathVar (v, env)) means that env is "this" 
> when the method was called. 

The intention was to merge the original object ("env") with the updated 
one ("obj"), except I was not doing it right in case the path was longer 
than 1 element.

> What you want to do is restore the env

Why would you want to restore the env. Currently, env is the object 
_value_ of the head variable prior to method call. The "this" namespace 
is set to env prior to the actual call, but then "this" should go away.

In any case, we also carry the venv_obj around (which includes the same 
env as venv_this), so the env in PathVar appears to be simply redundant.

Aleksey