[Omake] SVN Commit: Mojave standard library (Rev. 11387)

[Jason Hickey]

Libmojave had broken because you hadn't updated all the calls to  
Mutex.create to use strings instead of unit.  We (David) needed a  
compiling libmojave, so I pushed the patch through.

If you need this kind of thing, and you don't have time to check all  
the architectures, what about using an optional argument?

    let create ?debug () = ...

Of course, it would be nice if we could actually figure out a way to  
typecheck the dead code...

Jason

On Jul 23, 2007, at 1:06 PM, Aleksey Nogin wrote:

> Jason,
>
> This does not compile! The Lm_thread.Mutex is Lm_thread_core_ 
> {null,sys).MutexCore and that one still expects a debug string.
>
> Is there some reason why you need the original signature? It is  
> nice to be able to shadow Mutex with MutexDebug and have a debugged  
> version (like the commented out code in Lm_thread_pool_system does).
>
> Aleksey
>
> On 23.07.2007 12:59, Jason J. Hickey wrote:
>
>> Revert Lm_thread.Mutex.create : unit -> Mutex.t (not string ->  
>> Mutex.t).
>> ----
>> Changes:
>>     +4 -4	libmojave/stdlib/lm_thread.ml
>>     +4 -4	libmojave/stdlib/lm_thread_sig.ml
>>     +1 -1	libmojave/util/lm_hash.ml
>>     +4 -4	libmojave/util/lm_symbol.ml
>>  A hyperlinked version of this commit is available at
>> http://svn.metaprl.org/commitlogs/libmojave/ 
>> 2007-07.html#07/07/23.12:59:55
>
> _______________________________________________
> OMake-Devel mailing list
> OMake-Devel at metaprl.org
> https://lists.metaprl.org/mailman/listinfo/omake-devel

--
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257