[Omake] Lm_channel question.

Jason Hickey jyh at cs.caltech.edu
Mon Jul 16 14:09:09 PDT 2007


On Jul 16, 2007, at 1:48 PM, Aleksey Nogin wrote:

> Jason,
>
> A comment in lm_channel.ml says that "In binary mode, the  
> write_buffer is the same as the out_buffer." Is this supposed to be  
> an invariant? If so, if was violated in certain cases - and the  
> attached patch fixes it.
>
> P.S. I came across this when trying to understand the sprintf  
> problem, and I have no evidence that this change is needed for  
> anything other than keeping the code more self-consistent.

I think this patch is a good idea, if only to make the code easier to  
read.

Jason

--
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257





More information about the OMake-Devel mailing list