[Omake] SVN Commit: OMake Build System (Rev. 10534)

[Jason Hickey]

Aleksey,

Please explain to me.
    - Why do you take record patterns and turn them into projections?
    - Why do you want to use Unix.readdir directly when it is more  
complicated?
    - *Never* use wildcard exception patterns unless absolutely  
necessary!
    - Do you really intend to catch Stack_overflow and Out_of_memory  
exceptions?
    - *Never* open the Unix module!

There must be some reason for increasing the code complexity.

The calls to Unix.LargeFile.stat dwarf any other efficiency concerns  
in this code!  Increasing the control complexity of the code can not  
be justified on the basis of efficiency.

Jason

On Apr 27, 2007, at 11:24 AM, Aleksey Nogin wrote:

> Corrected couple of bugs and few minor inefficiencies that were  
> introduced
> into the fs case sensitivity testing code by rev. 10498  
> reorganization.
>
> ----
> Changes:
>     +42 -52	omake-branches/0.9.8.2/src/ir/omake_node.ml
>
> A hyperlinked version of this commit is available at
> http://svn.metaprl.org/commitlogs/omake/2007-04.html#07/04/27.11:24:55
>
> _______________________________________________
> OMake-CVS mailing list
> OMake-CVS at metaprl.org
> https://lists.metaprl.org/mailman/listinfo/omake-cvs

--
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257