[Omake] SVN Commit: OMake Build System [0.9.8.x] (Rev. 9345)

Aleksey Nogin nogin at cs.caltech.edu
Mon Jun 19 06:07:26 PDT 2006


On 18.06.2006 19:38, Jason Hickey wrote:

> Module name: OMake Build System [0.9.8.x]
> Changes by: jyh at cs.caltech.edu (Jason Hickey)
> Date: 2006-06-18 19:37:52 -0700 (Sun, 18 Jun 2006)
> Revision: 9345
> Log message:
>       
>       Added --divert options.
>       
>          --divert : divert output from commands so it can be printed later.
>          --divert-repeat : repeat diverted output when a command is finished.
>          --divert-only : print only diverted output, omake will be quiet otherwise.
>       

Perhaps I am missing something, but what's the point of having the first 
option? Shouldn't it just be implicitly defined by the other two?

Also, I think that the space of reasonable options is a bit different. 
The complete set of choices is:
1) whether to print the output while the command is executed
2) successful executions:
    a) whether to [re]print the whole thing in a single block when it is 
finished
3) failed executions:
    a) whether to [re]print the whole thing in a single block when it is 
finished
    b) whether to [re]print the whole thing in a single block when OMake 
is finished (or is in the no-op FAM loop).

Note:

- if both (1) and (2a) are disabled, we get the "really quiet" mode, 
where only the output of the failed commands is printed). This is good!

- I would claim that it does not make much sense to enable (2a) without 
(3a) (as the --divert-only will be doing according to the docs). The 
output from the failed commands is normally more important and 
postponing it until later only makes it impossible to start fixing bugs 
while OMake is still running.

P.S. Also, I think that we should be more consistent in adding --no-... 
forms to all these options. This way it's easier to make some of these 
enabled by default in some circumstances.

P.P.S. How about making "-j" imply "disable 1, enable 2a/3a" and making 
"-k/-p/-P" imply "enable 3b"?

-- 
Aleksey Nogin

Home Page: http://nogin.org/
E-Mail: nogin at cs.caltech.edu (office), aleksey at nogin.org (personal)
Office: Moore 04, tel: (626) 395-2200


More information about the OMake-Devel mailing list