[Omake] [Ping Jason] [0.9.8] Weird (obsolete?) code causing 0-arg commands in rules to be ignored!

[Jason Hickey]

Aleksey Nogin wrote:
> Jason,
> 
> The src/ir/omake_command.ml file currently contains the following:
> 
>> let parse_commands venv dir target loc lines =
>>    let lines =
>>       List.fold_left (fun lines (flags, line) ->
>>             match line with
>>                CommandPipe (PipeCommand (_, { cmd_argv = [] })) ->
>>                   lines
>>              | _ ->
>>                   parse_command venv dir target loc flags line :: 
>> lines) [] lines
>>    in
>>       List.rev lines
> 
> 
> This code kills any commands that do not take arguments (took me quite a 
> while to debug :-( )! Am I right assuming that the "cmd_argv = []" case 
> is an obsolete remnant of the times when cmd_argv included the 
> executable as well and should simply be deleted?

Ah, so that is what was happening, I just noticed it too.  Yes, this is 
bogus in the current arg scheme.

Jason

-- 
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257