[Omake] [0.9.8] Would it be reasonable to pretty-print internally executed command lines differently?

[Jason Hickey]

This seems reasonable, but I don't know about printing the environment. 
  We wouldn't want to display a full dump each time a shell command is 
executed...

Jason

Aleksey Nogin wrote:
> I was debugging something in 0.9.8 and I realized that in the 0.9.8 
> setup it would be very easy to emphasize (in "+ ..." lines, etc) which 
> commands are executed internally.
> 
> Jason, what would you think about the idea of doing something like
> 
> --- src/ir/omake_shell_type.ml  (revision 9253)
> +++ src/ir/omake_shell_type.ml  (working copy)
> @@ -237,7 +237,7 @@
>              apply_append = append
>            } = apply
>        in
> -         fprintf buf "@[<hv 3>%a%a%a%a%a@]" (**)
> +         fprintf buf "@[<hv 3>%a%a(%a )%a%a@]" (**)
>              pp_print_env env
>              pp_print_symbol f
>              pp_print_args args
> @@ -302,12 +302,9 @@
> 
> Or may be even
> 
> --- src/ir/omake_shell_type.ml  (revision 9253)
> +++ src/ir/omake_shell_type.ml  (working copy)
> @@ -237,7 +237,7 @@
>              apply_append = append
>            } = apply
>        in
> -         fprintf buf "@[<hv 3>%a%a%a%a%a@]" (**)
> +         fprintf buf "@[<hv 3>%aShell.%a(%a )%a%a@]" (**)
>              pp_print_env env
>              pp_print_symbol f
>              pp_print_args args
> @@ -302,12 +302,9 @@
> 


-- 
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257