[Omake] [Ping Jason] [0.9.8] Weird (obsolete?) code causing 0-arg commands in rules to be ignored!

Aleksey Nogin nogin at cs.caltech.edu
Tue Jun 6 13:01:44 PDT 2006


Jason,

The src/ir/omake_command.ml file currently contains the following:

> let parse_commands venv dir target loc lines =
>    let lines =
>       List.fold_left (fun lines (flags, line) ->
>             match line with
>                CommandPipe (PipeCommand (_, { cmd_argv = [] })) ->
>                   lines
>              | _ ->
>                   parse_command venv dir target loc flags line :: lines) [] lines
>    in
>       List.rev lines

This code kills any commands that do not take arguments (took me quite a 
while to debug :-( )! Am I right assuming that the "cmd_argv = []" case 
is an obsolete remnant of the times when cmd_argv included the 
executable as well and should simply be deleted?

-- 
Aleksey Nogin

Home Page: http://nogin.org/
E-Mail: nogin at cs.caltech.edu (office), aleksey at nogin.org (personal)
Office: Moore 04, tel: (626) 395-2200


More information about the OMake-Devel mailing list