[Omake] Re: [Setup] Lock results

[Jason Hickey]

Aleksey Nogin wrote:
> Actually, it is Unix.Unix_error (one thing that I did was also mapping 
> some of the Windows error messages to the corresponding Unix_error). If 
> something is translating it to Failure, this is probably happening 
> somewhere in OMake, not in LM. Basically, we may need to include 
> exception handling of the sort that is done in Omake_build.wait_for_lock 
> in other places where we take locks.
> 
Ah right, I misspoke.  But what I mean is that we should not have to 
pattern-match on the string to catch the exception.  Since the error 
means something, we should translate the exception to something that is 
easier to remember and less likely to miss, like LockNotSupported or 
something.

Jason

-- 
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257