[Omake] Output indentation?

[Aleksey Nogin]

On 11.12.2006 15:23, Jason Hickey wrote:

> 
> On Dec 11, 2006, at 3:08 PM, Aleksey Nogin wrote:
> 
>> On 11.12.2006 14:53, Jason Hickey wrote:
>>
>>> I am seeing some new display behavior on errors.
>>
>> The "--output-at-end" output is indented.
> 
> Is there a reason for it?  

Yes, it clearly delineates the outputs related to other targets.

I simply took the already existing summary message

*** omake: targets were not rebuilt because of errors:
   foo
      depends on: x
   bar
      depends on: y

and added the outputs to it

*** omake: targets were not rebuilt because of errors:
   bar
      depends on: y
      - build . bar
      + Shell.echo(bar Part 1)
      bar Part 1
      - build . bar
      + Shell.echo(bar Part 2)
      bar Part 2
      - build . bar
      + Shell.echo(bar Part 3) ; false
      bar Part 3
   foo
      depends on: x
      - build . foo
      + Shell.echo(foo Part 1)
      foo Part 1
      - build . foo
      + Shell.echo(foo Part 2)
      foo Part 2
      - build . foo
      + Shell.echo(foo Part 3) ; false
      foo Part 3

(the original approach of repeating the list of the failed targets twice
was IMO clearly suboptimal).

> It seems a little strange to me, 

I agree that it might be a bit strange, but in my experience it is very
easy to read - most of the time (probably much more so in cases of short
error messages, and much less so for huge LaTeX outputs).

In fact, when I have the --output-normal --output-at-end mode enabled,
and only one command producing the output (so that the indented and
non-indented versions are really close on the screen), I found that it
is much quicker for me to pick up the error from the indented version.

> and it
> potentially messes up output that has been formatted for the particular
> terminal width.

Well, the stdout/stderr of OMake jobs is never a tty and the stdin is
likely to follow in future versions, so the output is not expected to be
formatted for the specific tty.

Aleksey