[Omake] SVN Commit: OMake Build System (Rev. 9061)

[Jason Hickey]

Aleksey Nogin wrote:
> This makes me somewhat uncomfortable. Wouldn't you say that this 
> optimization was OK before, but with the new shell semantics this is no 
> longer reasonable?
> 
> In particular, I would expect that shell special symbols (semicolon, 
> etc) would be taken literally in ValData and would be acted upon in 
> ValString.

You are right.  Here are the places where the optimization happens:

    - Omake_eval.simplify_quote_val
    - Omake_eval.values_of_value

The first is clearly ok, because it is optimizing the data inside a 
ValQuote.

The second is less clear.  The values_of_value is used everywhere.

Consider the current new behavior.

osh> X = *
osh> $X
...ls output...
osh> Y = $(addprefix *, .c)
osh> $Y
ls: *.c: no such file or directory

Once a sequence gets converted to an array, all special characters 
become quoted.  This can be changed, but it would have to apply to all 
arrays.

C[] =
    ls
    *

Either:
    osh>$C
    *: file not found
or:
    osh>$C
    ...output from ls...

Jason

-- 
Jason Hickey                  http://www.cs.caltech.edu/~jyh
Caltech Computer Science      Tel: 626-395-6568 FAX: 626-792-4257