[Omake] SVN Commit: OMake Build System [0.9.8.x] (Rev. 11850)

Jason J. Hickey jyh at cs.caltech.edu
Mon Aug 6 14:14:04 PDT 2007


The hoisting Aleksey added in revs 11448-11849 was not right--
the following expression doesn't make sense:

   venv_export_venv venv_orig venv_src

This is because the two environments have different this.
venv_orig has the caller's "this", venv_src has the callee's "this".
The two objects are different, so the export makes no sense.

NOTE: disabled the path check, going back to the original policy
that hoisting overrides export.  This is matter of policy, so I
think it is better to keep the code simple, and discuss it.

Also, changed the tests a little, so an exit code of 2
is a "note", not an "error".

----
Changes in omake-branches/0.9.8.x:
    +17 -36     src/env/omake_env.ml
    +1 -1       src/env/omake_env.mli
    +1 -1       src/eval/omake_eval.ml
    +19 -3      test/OMakefile
    +4 -1       test/object/Test08
    +3 -2       test/object/Test10
    +4 -1       test/object/Test14
    +4 -1       test/object/Test15
    +1 -1       test/simple/Test8/run.osh
    +2 -2       test/targets/Test3/run.osh
 
A hyperlinked version of this commit is available at
http://svn.metaprl.org/commitlogs/omake/2007-08.html#07/08/06.14:14:04



More information about the OMake-CVS mailing list